SectionPage vs. SectionRootPage

[Vincent Van Den Berghe]

On 6.0.4 preview:

A SectionPage has the following fields:

section
sequence
level
flags
pages[]

A SectionRootPage derives from RootPage, and has the following fields:

section
sequence
level
pages[]

A SectionRootPage is therefore not interchangable with a SectionPage, because the flags field is missing from its layout definition.

A SectionRootPage isn't used anywhere: its only job is to create the section root page at the fixed page position SECTION_ROOT.

However, in Section.cpp in method getSectionRoot(), we see a call to getSectionPage with SECTION_ROOT as argument. The rest of the code in Section.cpp seems to assume that all the section pages returned are "real" SectionPages. However, for the page at SECTION_ROOT, this is not the case. Since they are not interchangable, isn't this problematic (or at the very least confusing)? Wouldn't a better design be to get rid of SectionRootPage altogether?


Vincent