CancelTask performance issue

[Erdinc Taskin]

Hi,
I analyse my applications that has small performance problem on jdbc connector classs that com.mysql.jdbc.StatementImpl.CancelTask constructor.


this.origConnProps = new Properties();
Properties props = StatementImpl.this.connection.getProperties();
Enumeration<?> keys = props.propertyNames();
while (keys.hasMoreElements()) {
String key = keys.nextElement().toString();
this.origConnProps.setProperty(key, props.getProperty(key));
}

One of the following changes is might make sense for performance improvements

this.origConnProps = new Properties(StatementImpl.this.connection.getProperties());

Another alternative
this.origConnProps = Properties();
this.origConnProps.putAll(StatementImpl.this.connection.getProperties());

Yes, I know first one is not deep copy and property changes will be reflected on CancelTask, but second is pretty same behave like current version.

Thanks for advance,