Re: Rewrite of a Old MYSql Statement

[Barry Galbraith]

I rewrote your query to be more reable like this

SELECT f.pdffieldname AS name
, s.pdftaxmode AS taxmode
, s. * AS selected
, a.position AS active
, f.quotes_g_enabled AS group_enabled
, f.quotes_i_enabled AS individual_enabled
FROM crmnow_pdfcolums_sel s
INNER JOIN crmnow_pdfcolums_active a
 ON  a.pdfmodulname = s.pdfmodul 
INNER JOIN crmnow_pdf_fields f
 ON a.pdftaxmode = s.pdftaxmode
WHERE pdfmodul = 'Quotes'
AND f.pdffieldname = 'Position'

So it's a bit easier to see what's wrong with it.

Remove the * by naming the fields you want from that table. You can't alias the many fields returned with one name.

This join condition

INNER JOIN crmnow_pdf_fields f
 ON a.pdftaxmode = s.pdftaxmode

doesn't use the joined table!!! You join to crmnow_pdf_fields and then specify the ON condition to be fields in crmnow_pdfcolums_active and crmnow_pdfcolums_sel.

You need to have a clearer idea of what you are looking for.

Good luck,
Barry.