Need feedback with my DB design

[Nanda Yadav]

Hi,
This is my first attempt at designing a db with lots of attributes and records. I have the following 3 tables(among few other tables)
1. client_sites(id, site_url, name...)
2. competitor_sites(id, site_url, name, clent_sites_id..)
3. domain_externals(id, google_rank, yahoo_rank, .....other metrics)

Each client site can have 1 to 10 or so competitor sites, so i have client_sites_id foreign key in competitor_sites resulting in 1..many relationship. Now, domain_externals table has 10 or so fields which are needed for both client_sites and competitor_sites. Right now I have two FKs, client_sites_id and competitor_sites_id in that table and it's a 1..1 relatioship to both the *_sites tables. Is it a good practice or shall I just create a separate competitor_domain_externals table for competitor_sites and client_domain_externals table for client_sites?
Thanks.



Edited 1 time(s). Last edit at 08/21/2007 10:13AM by Nanda Yadav.