Error in OK packet documentation?

[Michael Lenaghan]

The OK packet documentation (https://dev.mysql.com/doc/internals/en/packet-OK_Packet.html) says:

These rules distinguish whether the packet represents OK or EOF:

OK: header = 0 and length of packet > 7

EOF: header = 0xfe and length of packet < 9

In the face of the new CLIENT_DEPRECATE_EOF capability I'm not sure what to make of that; is it talking about new style OK packets that can have a header of either 0 *or* 0xfe, or is it talking about old-style OK packets with a 0 header and old-style EOF packets with a 0xfe header?

I *think* it's talking about old-style packets, because new-style OK packets, which can act as either OK or EOF (and have either a 0 or a 0xfe header) seem to have a minimum length of 8. In fact, they really have a minimum length of 12, because you can't have CLIENT_DEPRECATE_EOF without CLIENT_PROTOCOL_41.

Anyway, very difficult to parse—and perhaps actively misleading now that OK packets can have 0xfe headers.