Re: procedure with if

[Peter Brawley]

Design problems:

1. The sproc seeks to work around the possibility that the target table does not have the structure required by the data manipulation requirement. This is a serious design error. Database structures need to be verified entirely before any data manipulation code runs.

2. The data manipulation this sproc tries to implement could be solved much more simply and effectively with straghtforward sql: insert intoi reg_conb ... select ... from tbl_conbp...


Syntax errors:

1. ...if(cursor_conbp) INSERT INTO... should be ...if cursor_conbp THEN INSERT INTO...

2. In ...UPDATE reg_conbp SET NEW_CONBP_FECHA = v_fecha and NEW_CONBP_MONTO = v_monto, lose the AND.


Logic problems:

1. ...if(cursor_conbp) INSERT INTO... is illogical. If cursor creation failed, the sproc will not reach this line---it will have crashed out with a cursor creation error.

2. The variable getConbp is never set, so if everything else works, the loop will run forever.

3. MySQL will let you use the same name for a label and a variable, but it's bad practice because it invites confusion.