Simply stored proc works OK but is it correct syntax ?

[Russel James]

Hi folks,

I have been working on a stored proc. I eventually got it to work correctly but I am not sure if 'my way' of doing it is the correct way.

Here is the sproc:

CREATE DEFINER=`root`@`localhost` PROCEDURE `usp_SettlementWages`(
IN p_crewID varchar(4)
)
BEGIN

/* Get Current Wages Year and Insert into Wages table */
SELECT clYear INTO @wagesYear FROM sysControl;
SET @wagesYear = CONCAT('wages', @wagesYear);


SET @crewID = CONCAT('"', p_crewID, '"'); // Is this correct ??


SET @s = CONCAT("INSERT INTO ", @wagesYear, "(crewID) VALUES (", @crewID, ")");

PREPARE stmt FROM @s;
EXECUTE stmt;

END